feat(agent): add Conjur JWT authentication client - #821
Open
roeezis wants to merge 4 commits into
Open
Conversation
mladen-rusev-cyberark
left a comment
mladen-rusev-cyberark
left a comment
Collaborator
There was a problem hiding this comment.
Shape is right — plugs into the existing RequestAuthenticator seam, fails closed on non-200, and unlike the legacy identity client it refreshes its own token. Main concern is the token lifetime handling (inline).
Two smaller things: New and MockConjurExchangeServerStatus are missing doc comments; and buildJWSToken only emits base64.StdEncoding, so three of the four encodings conjurTokenObject claims to tolerate (raw JSON, URL-safe base64, unpadded) are never exercised — a table test over all four would be cheap.
roeezis
force-pushed
the
split/04-conjur-client
branch
from
August 24, 2026 11:42
b29357f to
81d45a9
Compare
added 2 commits
August 24, 2026 14:43
Introduces a small, isolated interface for reading a JWT from a file path — the first piece of the upcoming Conjur JWT authentication path, split out on its own since nothing else in this PR depends on it yet.
identity.go mixed the shared client/token-cache plumbing with the CyberArk Identity username/password (UP) login flow. Move the UP-specific code into username_password.go so the shared plumbing stays easy to find once a second login mechanism (Conjur JWT) is added alongside it. No behavior change — pure extraction, plus exporting the mock's success credentials for other packages' tests.
roeezis
force-pushed
the
split/04-conjur-client
branch
from
August 24, 2026 11:45
81d45a9 to
b59e43d
Compare
Author
|
All three addressed:
|
mladen-rusev-cyberark
approved these changes
Aug 24, 2026
added 2 commits
August 24, 2026 19:34
The Service Discovery API returns several independently-hosted services; the authn-jwt exchange this PR series adds is served by secrets_manager, a different host from identity_administration. Add a SecretsManager field to Services and parse it, so callers have it available — nothing reads it yet, that lands in a later PR alongside the client that needs it. secrets_manager and discoveryContext are deliberately not required here unlike identity, since not every caller needs them and requiring secrets_manager would break every existing username/password install on a tenant not yet onboarded to Conjur — each caller validates what it needs at its own point of use instead. identity, by contrast, is required unconditionally: it's present and active for every healthy tenant, so callers may rely on it without re-checking. Factor the repeated "find the first active main endpoint" loop into a mainActiveAPI helper now that there are three near-identical copies.
Exchanges a projected ServiceAccount JWT (via jwtsource) for a Conjur access token through the authn-jwt endpoint, and authenticates requests with it as identity.RequestAuthenticator. Nothing wires this in yet — that's the next PR, once both this and the legacy identity client exist side by side. The identity returned for audit tagging is the token's own sub claim when it can be extracted, falling back to the configured service ID otherwise. The cache expiry is driven by the token's own exp claim when present, falling back to a guessed TTL only when it isn't — a fixed TTL stamped after the exchange returns would otherwise serve a token past its real expiry under latency or clock skew. Exposes Invalidate() so a caller that gets a 401 from the resource server can force a fresh exchange instead of waiting out the cache.
roeezis
force-pushed
the
split/04-conjur-client
branch
from
August 24, 2026 16:38
b59e43d to
23492e8
Compare
Author
|
Took the suggested comment as-is — accurately scopes the current guarantee without overclaiming. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part 4 of the SMS/Conjur JWT authentication series (split out of #817). Stacked on #818, #819, and the service-discovery PR — diff will shrink once those merge.
Exchanges a projected ServiceAccount JWT (via the jwtsource package from #818) for a Conjur access token through the authn-jwt endpoint, and authenticates requests with it as
identity.RequestAuthenticator. Nothing wires this in yet — that's the next PR, once both this and the legacy identity client exist side by side.The identity returned for audit tagging is the token's own
subclaim when it can be extracted, falling back to the configured service ID otherwise, so an unusual token shape degrades rather than fails the request.Test plan
go build ./...go test ./internal/cyberark/conjur/...